Builder CrWinGoma Build #30608
Results:
build successful
Trigger Info:
Got Revision | bfdee36d31a624d330b60b481fc26d10dff81b97 |
Execution:
- Source: chromium.fyi/CrWinGoma/30608
- Bot: build28-m1
Steps and Logfiles:
Show:-
( 5 ms ) ensure_goma.install cipdensure_goma.install cipdcipd instance_id: bccdb9a605037e3dd2a8a64e79e08f691a6f159d
-
( 10 secs ) read test specread test specpath: C:\b\build\slave\CrWinGoma\build\src\testing\buildbot\chromium.fyi.json
Build Properties:
Name | Value | Source |
---|---|---|
got_angle_revision | "07529ff8dcacd94b93d432122d0c6aa68631843a" | Annotation(bot_update) |
got_buildtools_revision | "8dd3c8e39a48743c4eb790d9a8abe9676b617046" | Annotation(bot_update) |
got_nacl_revision | "f9308087f764c0f4341e3200baded605c917eb49" | Annotation(bot_update) |
got_revision | "bfdee36d31a624d330b60b481fc26d10dff81b97" | Annotation(bot_update) |
got_revision_cp | "refs/heads/master@{#398661}" | Annotation(bot_update) |
got_swarming_client_revision | "df6e95e7669883c8fe9ef956c69a544154701a49" | Annotation(bot_update) |
got_v8_revision | "af2ed87b122bd32cc53285dc7579530ae08731e5" | Annotation(bot_update) |
got_v8_revision_cp | "refs/heads/5.3.182@{#1}" | Annotation(bot_update) |
got_webrtc_revision | "393886f22bb16e991b0fc57d7e290637d307448a" | Annotation(bot_update) |
got_webrtc_revision_cp | "refs/heads/master@{#13070}" | Annotation(bot_update) |
recipe | "chromium" | Annotation(setup_properties) |
build_revision | "94dbe001292dcec3423c5d1b0374826ff89a8f46" | Annotation(update_scripts) |
build_scm | "git" | Annotation(update_scripts) |
blamelist | ["agrieve@chromium.org","dcheng@chromium.org","dtseng@chromium.org","fsamuel@chromium.org","gab@chromium.org","moshayedi@chromium.org","yolandyan@google.com"] | Build |
branch | "master" | Build |
buildnumber | 30608 | Build |
project | "chromium" | Build |
repository | "https://chromium.googlesource.com/chromium/src" | Build |
requestedAt | 1465417476 | Build |
revision | "bfdee36d31a624d330b60b481fc26d10dff81b97" | Build |
slavename | "build28-m1" | BuildSlave |
buildername | "CrWinGoma" | Builder |
git_revision | "bfdee36d31a624d330b60b481fc26d10dff81b97" | Change |
scheduler | "chromium" | Scheduler |
buildbotURL | "http://build.chromium.org/p/chromium.fyi/" | master.cfg |
mastername | "chromium.fyi" | master.cfg |
workdir | "C:\\b\\build\\slave/CrWinGoma" | slave |
Blamelist:
- (moshayedi @chromium.org)
- (fsamuel @chromium.org)
- (gab @chromium.org)
- (dtseng @chromium.org)
- (yolandyan @google.com)
- (dcheng @chromium.org)
- (agrieve @chromium.org)
Timing:
Create | N/A |
Start | Wednesday, 08-Jun-16 20:37:26 UTC |
End | Wednesday, 08-Jun-16 20:52:56 UTC |
Pending | N/A |
Execution | 15 mins 30 secs |
All Changes:
-
Remove type converters for ui::Event.
Changed by moshayedi @chromium.orgChanged at Wednesday, 08-Jun-16 20:23:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 74b54c510611ebaa8479d004a6878abe96e372d3 Comments
Remove type converters for ui::Event. We are using struct traits for serializing/deserializing ui::Event and don't need type converters anymore. BUG=578206 Review-Url: https://codereview.chromium.org/2048633004 Cr-Commit-Position: refs/heads/master@{#398655}
Changed files
- ash/mus/BUILD.gn
- ash/mus/frame/non_client_frame_view_mash.cc
- ash/mus/window_manager_application.cc
- ash/sysui/BUILD.gn
- components/mus/public/cpp/BUILD.gn
- components/mus/public/cpp/lib/window_tree_client.cc
- components/mus/public/cpp/tests/BUILD.gn
- components/mus/public/cpp/tests/window_tree_client_private.cc
- components/mus/public/cpp/tests/window_tree_client_unittest.cc
- components/mus/ws/BUILD.gn
- components/mus/ws/event_dispatcher.cc
- components/mus/ws/event_matcher.cc
- components/mus/ws/platform_display.cc
- components/mus/ws/window_server.cc
- components/mus/ws/window_tree.cc
- content/renderer/mus/BUILD.gn
- content/renderer/mus/compositor_mus_connection.cc
- ui/events/mojo/BUILD.gn
- ui/events/mojo/input_events_type_converters.cc
- ui/events/mojo/input_events_type_converters.h
- ui/events/mojo/mojo_extended_key_event_data.cc
- ui/events/mojo/mojo_extended_key_event_data.h
- ui/events/mojo/mojo_input_events_export.h
- ui/views/mus/BUILD.gn
-
StructTraits optimizations
Changed by fsamuel @chromium.orgChanged at Wednesday, 08-Jun-16 20:25:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 605998f30d05bb8d323542c1039e64e1afce696b Comments
StructTraits optimizations Pass more things by const reference and read directly into output. BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2047963004 Cr-Commit-Position: refs/heads/master@{#398656}
Changed files
- cc/ipc/returned_resource_struct_traits.h
- cc/ipc/selection_struct_traits.h
- cc/ipc/shared_quad_state_struct_traits.h
- cc/ipc/transferable_resource_struct_traits.h
- gpu/ipc/common/mailbox_holder_struct_traits.h
-
Manual refactor to enum-based WaitableEvent for remaining _win files
Changed by gab @chromium.orgChanged at Wednesday, 08-Jun-16 20:25:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7c19b196f653ec0e2b3aab703611231efc04cb2a Comments
Manual refactor to enum-based WaitableEvent for remaining _win files BUG=612843 R=fdoray@chromium.org TBR=danakj@chromium.org (Francois please fact check me, I'm TBRing dana for otherwise mechanical change) Review-Url: https://codereview.chromium.org/2047163003 Cr-Commit-Position: refs/heads/master@{#398657}
Changed files
- base/sync_socket_win.cc
- chrome/browser/chrome_select_file_dialog_factory_win.cc
- chrome/browser/password_manager/password_store_win_unittest.cc
- components/policy/core/common/policy_loader_win.cc
- net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc
- net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc
-
Add role lists to ChromeVox.
Changed by dtseng @chromium.orgChanged at Wednesday, 08-Jun-16 20:27:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b0b4c0099b04f00b117595a762d09eb3e692f944 Comments
Add role lists to ChromeVox. - add lists for forms, headings, landmarks, links, and tables. - fix some focusing issues with menus BUG=617670 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2042083002 Cr-Commit-Position: refs/heads/master@{#398658}
Changed files
- chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
- chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
- chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
- chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
-
Add DisableIf annotation to EME test
Changed by yolandyan @google.comChanged at Wednesday, 08-Jun-16 20:30:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ea1675fb67d48828efb8c6b168582aa9f33388a2 Comments
Add DisableIf annotation to EME test EME test does not pass on AOSP Android, therefore, add DisableIf annotation to it (from BaseInstrumentationTestRunner) Reorganized BaseInstrumentationTestRunner so it doesn't include anything unrelated to WebViewLayout Testing. BUG=607350 Review-Url: https://codereview.chromium.org/1952573002 Cr-Commit-Position: refs/heads/master@{#398659}
Changed files
- android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
- android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTestRunner.java
- base/test/android/javatests/src/org/chromium/base/test/util/DisableIf.java
- base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
-
Revert of service worker: Don't control a subframe of an insecure context (patchset #21 id:440001 of https://codereview.chromium.org/2009453002/ )
Changed by dcheng @chromium.orgChanged at Wednesday, 08-Jun-16 20:32:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c363d41a6001cb7b27789484702d23fa4572a918 Comments
Revert of service worker: Don't control a subframe of an insecure context (patchset #21 id:440001 of https://codereview.chromium.org/2009453002/ ) Reason for revert: ServiceWorkerProviderHost::SetControllerVersionAttribute CHECK is firing in release builds: crbug.com/618365">https://crbug.com/618365 Original issue's description: > service worker: Don't control a subframe of an insecure context > > We must check isSecureContext when creating the network provider to > adhere to https://w3c.github.io/webappsec/specs/pow ...skip... ux:linux_site_isolation > > Committed: https://crrev.com/59a2e54eeb0e61971a0c27c44c54dd0c30b5d06d > Cr-Commit-Position: refs/heads/master@{#398229} TBR=alexmos@chromium.org,clamy@chromium.org,horo@chromium.org,jww@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,falken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=607543 Review-Url: https://codereview.chromium.org/2055433002 Cr-Commit-Position: refs/heads/master@{#398660}
Changed files
- chrome/browser/chrome_content_browser_client.cc
- chrome/browser/chrome_content_browser_client.h
- chrome/browser/extensions/service_worker_apitest.cc
- content/browser/service_worker/service_worker_browsertest.cc
- content/browser/service_worker/service_worker_context_core.cc
- content/browser/service_worker/service_worker_context_request_handler_unittest.cc
- content/browser/service_worker/service_worker_context_unittest.cc
- content/browser/service_worker/service_worker_controllee_request_handler.cc
- content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
- content/browser/service_worker/service_worker_dispatcher_host.cc
- content/browser/service_worker/service_worker_dispatcher_host.h
- content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
- content/browser/service_worker/service_worker_handle_unittest.cc
- content/browser/service_worker/service_worker_job_unittest.cc
- content/browser/service_worker/service_worker_provider_host.cc
- content/browser/service_worker/service_worker_provider_host.h
- content/browser/service_worker/service_worker_provider_host_unittest.cc
- content/browser/service_worker/service_worker_request_handler_unittest.cc
- content/browser/service_worker/service_worker_storage_unittest.cc
- content/browser/service_worker/service_worker_url_request_job_unittest.cc
- content/browser/service_worker/service_worker_version_unittest.cc
- content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
- content/child/service_worker/service_worker_network_provider.cc
- content/child/service_worker/service_worker_network_provider.h
- content/common/service_worker/service_worker_messages.h
- content/public/browser/content_browser_client.h
- content/renderer/render_frame_impl.cc
- content/renderer/service_worker/service_worker_context_client.cc
- content/renderer/shared_worker/embedded_shared_worker_stub.cc
- third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html
- third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/insecure-inscope.html
- third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/insecure-parent.html
- third_party/WebKit/Source/core/dom/Document.cpp
- third_party/WebKit/Source/core/dom/Document.h
- third_party/WebKit/Source/core/frame/Frame.cpp
- third_party/WebKit/Source/core/frame/Frame.h
- third_party/WebKit/Source/web/WebFrame.cpp
- third_party/WebKit/Source/web/tests/WebFrameTest.cpp
- third_party/WebKit/public/web/WebFrame.h
-
Update GN docs about target_cpu to encourage use of current_cpu
Changed by agrieve @chromium.orgChanged at Wednesday, 08-Jun-16 20:32:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bfdee36d31a624d330b60b481fc26d10dff81b97 Comments
Update GN docs about target_cpu to encourage use of current_cpu BUG=616819 Review-Url: https://codereview.chromium.org/2038733003 Cr-Commit-Position: refs/heads/master@{#398661}
Changed files
- tools/gn/docs/cross_compiles.md
- tools/gn/variables.cc